fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList #25172
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against c16f83e22aadf7756bf50d7f72d1ffa4b991dd11 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e192651:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c16f83e22aadf7756bf50d7f72d1ffa4b991dd11 (build) |
|
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
msft-fluent-ui-bot
added
the
Resolution: Soft Close
github-actions
bot
modified the milestones:
October Project Cycle Q4 2022,
March Project Cycle Q1 2023
github-actions
bot
modified the milestones:
March Project Cycle Q1 2023,
April Project Cycle Q2 2023
khmakoto
approved these changes
Apr 21, 2023
packages/react-examples/src/react/ContextualMenu/ContextualMenu.CustomMenuList.Example.tsx
Outdated
Show resolved
Hide resolved
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 24, 2023
* master: (58 commits) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) fix document link (microsoft#27499) fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467) chore(react-tabs): adopts custom JSX pragma (microsoft#27640) fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650) feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378) bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642) applying package updates feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637) feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557) ...
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
…stomMenuList (microsoft#25172) Co-authored-by: Makoto Morimoto <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
* feat/drawer-components: (81 commits) docs: remove TODO marks fix: remove conflict code leftover applying package updates microsoft#25730: TimePicker Default Value Fix, Controllable Usage, Example Updates (microsoft#26482) docs(react-datepicker-compat): Add description to README.md (microsoft#27677) Updated to use single hook selector (microsoft#27491) fix: Make border around Avatar's badge transparent using a mask (microsoft#27527) Disable focus on non-interactive elements (microsoft#27580) feat(react-drawer): implement "prevent close on click outside" feature (microsoft#27551) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Up and Down arrow navigation is broken in
ContextualMenuWithCustomMenuListExampleNew Behavior
Implement necessary key handling workaround for the arrow navigation to work as expected.
See #20074 (comment) for details.
Related Issue(s)
Fixes #20074